From: Florian Müllner <fmuellner@gnome.org>
Date: Thu, 20 Jan 2011 15:46:55 +0000 (+0100)
Subject: overview: Always return a value in _onDragMotion()
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~9224
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=df3560143d07207b17af7fb7e33b7aec4238c998;p=gnome-shell.git

overview: Always return a value in _onDragMotion()

Drag monitor functions are supposed to return a value, but
_onDragMotion() does not always do so. Add the missing return
value and remove unnecessary else.
---

diff --git a/js/ui/overview.js b/js/ui/overview.js
index 7aa24237e..35c1b05c4 100644
--- a/js/ui/overview.js
+++ b/js/ui/overview.js
@@ -207,9 +207,9 @@ Overview.prototype = {
 
         if (targetIsWindow &&
             dragEvent.targetActor._delegate.metaWindow == this._lastHoveredWindow)
-            return;
-        else
-            this._lastHoveredWindow = null;
+            return DND.DragMotionResult.CONTINUE;
+
+        this._lastHoveredWindow = null;
 
         if (this._windowSwitchTimeoutId != 0) {
             Mainloop.source_remove(this._windowSwitchTimeoutId);